Repository navigation
[6.x] Fail contains field conditions against an object instead of throwing - #15535
Merged
jasonvarga merged 2 commits intoSep 29, 2026
Merged
Conversation
contains field conditions against an object instead of throwingcontains field conditions against an object instead of throwing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15534
A
containsorincludescondition on a field whose value is a plain object, such as a date range ({ start, end }) or agroup, threwTypeError: condition.lhs.includes is not a function.prepareLhs()passes objects through unchanged so that arrays keepincludes(), andpassesIncludesCondition()calledincludes()without checking it exists.passesIncludesCondition()now fails the condition when the value can't be searched, which matches howpassesCondition()already treats an object for every other operator (if (isObject(condition.lhs)) return false). Arrays and strings are unaffected, and underunlessthe failed condition still inverts as usual.Tests
Adds
it fails includes or contains conditions against an object instead of throwingtoresources/js/tests/FieldConditionsValidator.test.js, with a date range and a group-like object undercontains,includesandunless. On6.xwithout the change it throwsTypeError: condition.lhs.includes is not a function; with it, it passes. The file's other 52 tests still pass, andnpx vitest run --project unitpasses (628 tests).