Repository navigation
[6.x] Modal remove behind from accessibility tree - #15569
Merged
Merged
Conversation
…-hidden hides everything except the dialog so the page behind leaves the accessibility tree; the overlay stays clickable. Cleared on close.
Revealing on close() put the page back in the accessibility tree while the dialog was still visible and focus-trapped. Reveal in cleanup() after the 300ms wait instead.
Modal imports it directly; it should not rely on reka-ui hoisting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
When the license modal is active, the page behind stays in the accessibility tree.
What this PR Does
inertbut apparently this diverges from the Reka way of doing things, and not necessarily simplerHow to Reproduce
[]returned, which means that these nodes are not hidden from the accessibility tree.[...document.querySelectorAll('#statamic > [aria-hidden="true"]')] .map(el => el.tagName + (el.id ? '#' + el.id : ''))and you should see['DIV', 'HEADER', 'MAIN#main']returned, which means the DOM is hidden from the accessibility tree.