[17.09] Error on cluster spec name change - #2454
Merged
nishanttotla merged 1 commit intoNov 19, 2017
Merged
Conversation
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com> (cherry picked from commit 0b078d1) Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Contributor
Author
|
Ping @anshulpundir @thaJeztah |
anshulpundir
approved these changes
Nov 18, 2017
Contributor
|
Thx for doing this! @nishanttotla |
Member
|
Can someone restart CI? |
Codecov Report
@@ Coverage Diff @@
## bump_v17.09 #2454 +/- ##
===============================================
- Coverage 65.36% 60.22% -5.15%
===============================================
Files 80 128 +48
Lines 14477 26170 +11693
===============================================
+ Hits 9463 15761 +6298
- Misses 4241 9036 +4795
- Partials 773 1373 +600 |
Member
|
All green now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2436.
git cherry-pick -s -x 0b078d10da563bd8c1d4f3a795a81a5d2dbf5232Cherry-pick was clean.