Skip to content

Vanilla TextCell password - #2249

Closed
adammation wants to merge 8 commits into
eclipsesource:masterfrom
adammation:vanilla-textcell-password
Closed

Vanilla TextCell password#2249
adammation wants to merge 8 commits into
eclipsesource:masterfrom
adammation:vanilla-textcell-password

Conversation

@adammation

@adammation adammation commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

The input type for a TextCell in the vanilla-renderers was 'text' and could not be changed.

This change keeps the default 'text' type but allows the type to be changed via an option "type"

"options": { "format": "password" }

See also:
https://jsonforms.discourse.group/t/input-type-with-vanilla-renderers/272

For vanilla-renderers TextCell, use "type" option to select an alternative HTML5 input type such as "email" or "password"
@netlify

netlify Bot commented Jan 11, 2024

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 550fe09
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65a048777a337c0008fcf323
😎 Deploy Preview https://deploy-preview-2249--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant

CLAassistant commented Jan 11, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the contribution ❤️

In the React Material UI renderers we already support format: 'password' as the indicator to render a password field. Would this work for you too? I would prefer to be consistent between renderer sets.

@coveralls

coveralls commented Jan 11, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 84.798%. remained the same
when pulling 550fe09 on adammation:vanilla-textcell-password
into fce6b1e on eclipsesource:master.

@adammation

Copy link
Copy Markdown
Contributor Author

Hi! Thanks for the contribution ❤️

In the React Material UI renderers we already support format: 'password' as the indicator to render a password field. Would this work for you too? I would prefer to be consistent between renderer sets.

Sounds great, changed to format: "password"

@adammation
adammation requested a review from sdirix January 13, 2024 01:48
Comment on lines +53 to +55
type={
appliedUiSchemaOptions.format ? appliedUiSchemaOptions.format : 'text'
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type={
appliedUiSchemaOptions.format ? appliedUiSchemaOptions.format : 'text'
}
type={appliedUiSchemaOptions.format === 'password' ? 'password' : 'text'}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer only passing through the password as in React Material. Other types might be incompatible. I would have applied the change myself but maintainer editing was turned off for this PR

@sdirix

sdirix commented Jan 22, 2024

Copy link
Copy Markdown
Member

Closed in favor of #2254. Thanks for the contribution ❤️

@sdirix sdirix closed this Jan 22, 2024
@adammation

Copy link
Copy Markdown
Contributor Author

Thanks @sdirix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants