module: remove underscore modules from builtinModules and isBuiltin - #57540
Closed
dario-piotrowicz wants to merge 6 commits into
Closed
module: remove underscore modules from builtinModules and isBuiltin#57540dario-piotrowicz wants to merge 6 commits into
dario-piotrowicz wants to merge 6 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these changes remove modules starting with underscore (e.g.
__http_agent) fromModule#builtinModulesandModule#isBuiltinsince they are not properly documented as public. They can't easily be removed since many libraries use them, but their usage should be discouraged and they should not be exposed by such utilities