[6.x] Fix Combobox not displaying a selected option with a falsy value - #15037
Merged
Conversation
selectedOption, canClearSelection, shouldShowInput, and scrollToSelectedOption all used truthy checks on modelValue to detect "nothing selected". A legitimate value of 0, '', or false was treated the same as null, so certain options would never showed as selected in the trigger. Switched to the explicit modelValue === null check selectedOptions already used correctly. Signed-off-by: Beau Hastings <beau@saweet.net>
`originalValue` collapsed to `[]` for falsy single values like `0`, `''`, or `false`, causing the `selected` event to fire again for a value that was already selected. Same class of bug as the other `modelValue` checks fixed in this file.
`Combobox.stories.ts` already has an established pattern for testing Combobox's behaviour via `play` functions tagged `!dev`/`test`, run against a real browser through `@storybook/addon-vitest`. Replacing the standalone `Combobox.test.js` with `TestFalsyModelValue` keeps coverage for this fix consistent with how the rest of the component is tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selectedOption, canClearSelection, shouldShowInput, and scrollToSelectedOption all used truthy checks on modelValue to detect "nothing selected". A legitimate value of 0, '', or false was treated the same as null, so certain options would never showed as selected in the trigger. Switched to the explicit modelValue === null check selectedOptions already used correctly.