[6.x] Fix Outpost rate limiting and tests - #15114
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jasonvarga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where real requests would be sent to the Outpost when running an addon's test suite when testing Control Panel URLs.
This PR fixes it by configuring a fake cache store, like we do in our own tests.
This PR also fixes an issue where the CP could throw
ErrorException: Undefined array key 0when the Outpost rate limits a site. This was happening becausecacheAndReturnRateLimitResponse()assumed the response always includes aRetry-Afterheader, which isn't guaranteed. I've fixed it by falling back to five minutes when the header is missing or doesn't contain a number of seconds, matching the behaviour for other errors.