[6.x] Make Composer::isInstalled() fail gracefully when the lock file is missing - #15333
Merged
Conversation
…missing Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATXH2uZVrsXqYrGqUoKhQA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
Composer::isInstalled()throws aComposerLockFileNotFoundExceptionwhen thecomposer.lockfile doesn't exist.This was happening because it reads the lock file without checking it exists first, unlike
Composer::installed()andComposer::installedVersion(), which already fail gracefully when the lock file is missing.This PR fixes it by returning
falsewhen there's no lock file, since we can't know whether a package is installed without one. This is mostly an issue in addon test suites, where the Testbench skeleton doesn't include acomposer.lockfile, forcing addons to create a stub lock file whenever something in core callsComposer::isInstalled(). With the Forms 2 changes, that'll happen on every front-end form request viaStatamic::formsProInstalled().