feat: Add support for React error handlers - #1354
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 63ceda3:
|
4 tasks
eps1lon
force-pushed
the
error-handlers
branch
from
August 28, 2024 21:24
5c899f6 to
668f4d0
Compare
This was referenced Aug 29, 2024
eps1lon
marked this pull request as ready for review
August 29, 2024 12:28
eps1lon
force-pushed
the
error-handlers
branch
from
January 15, 2025 22:44
9a64089 to
4c02043
Compare
eps1lon
force-pushed
the
error-handlers
branch
from
January 15, 2025 23:13
4c02043 to
63ceda3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Alternate to #1333
Adds support for
onRecoverableErrorandonCaughtError(React 19 only)onUncaughtErroris not supported yet because there's no use. Therenderwould throw anyway. We're likely going to change that though in React.Why:
This allows test setups that fail on console errors to silence specific, expected errors in their tests.
Especially
onCaughtErrorwill simplify testing of error boundaries since it will disable React's default console.error + window.onError dispatch (see docs I'll add soon)How:
Forward mentioned options to React's
createRootcall.Checklist:
docs site: Docs for
onCaughtError,onRecoverableErrorand how to test error boundaries testing-library-docs#1424