build(build-system): Remove setuptools build dependency - #493
Closed
tjni wants to merge 1 commit into
Closed
Conversation
|
|
Author
|
I don't want to read and sign a CLA. Please feel free to do whatever you want with this minor code change. |
Member
|
Thanks for helping on the package on nixpkgs. I'd offer to have the CLA explained, but since you refused, yet also have this PR, I'm at an impasse. |
Member
|
Released v0.22.2 |
Author
|
Thank you for taking care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in 3bc03fb to support
pip install -e .but I noticed that (per python-poetry/poetry#34 (comment)), this is fixed inpip>= 21.3.For context, I am working on this package in nixpkgs and investigating if
setuptoolsis really needed as a build dependency.