Add implicit exports into __init__.py - #531
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 88.76% 88.38% -0.38%
==========================================
Files 37 37
Lines 3685 3798 +113
Branches 526 549 +23
==========================================
+ Hits 3271 3357 +86
- Misses 281 304 +23
- Partials 133 137 +4 ☔ View full report in Codecov by Sentry. |
tony
self-requested a review
March 2, 2024 00:29
tony
approved these changes
Mar 2, 2024
tony
left a comment
Member
There was a problem hiding this comment.
Works for me. Sphinx autodoc still seems to work.
Member
|
@ssbarnea I will cut a feature-level package release so you can try this downstream. |
tony
added a commit
that referenced
this pull request
Mar 2, 2024
Member
|
@ssbarnea This is live in v0.32.0 (PyPI, release notes, changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #530