Toughen ruff linting - #436
Merged
Merged
Conversation
src/vcspull/_internal/config_reader.py:49:39: EM102 [*] Exception must not use an f-string literal, assign to variable first src/vcspull/_internal/config_reader.py:112:39: EM102 [*] Exception must not use an f-string literal, assign to variable first src/vcspull/_internal/config_reader.py:187:39: EM102 [*] Exception must not use an f-string literal, assign to variable first Found 3 errors.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
==========================================
- Coverage 84.91% 84.32% -0.60%
==========================================
Files 16 16
Lines 935 938 +3
Branches 179 182 +3
==========================================
- Hits 794 791 -3
- Misses 90 93 +3
- Partials 51 54 +3 ☔ View full report in Codecov by Sentry. |
conftest.py:87:5: A001 Variable `dir` is shadowing a Python builtin docs/conf.py:56:1: A001 Variable `copyright` is shadowing a Python builtin src/vcspull/_internal/config_reader.py:29:15: A002 Argument `format` is shadowing a Python builtin src/vcspull/_internal/config_reader.py:53:19: A002 Argument `format` is shadowing a Python builtin src/vcspull/_internal/config_reader.py:109:13: A001 Variable `format` is shadowing a Python builtin src/vcspull/_internal/config_reader.py:111:13: A001 Variable `format` is shadowing a Python builtin src/vcspull/_internal/config_reader.py:163:9: A002 Argument `format` is shadowing a Python builtin src/vcspull/_internal/config_reader.py:192:20: A002 Argument `format` is shadowing a Python builtin tests/helpers.py:54:25: A002 Argument `format` is shadowing a Python builtin Found 9 errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ruff linting
flake8-commas (COM)
flake8-builtins (A)
flake8-errmsg (EM)