Linting: Aggressive ruff pass (ruff v0.3.4) - #442
Merged
Conversation
tony
force-pushed
the
ruff-all-v0.3.4-pass
branch
from
March 24, 2024 17:52
31596d0 to
bc7da59
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 84.32% 84.35% +0.02%
==========================================
Files 16 16
Lines 938 933 -5
Branches 182 182
==========================================
- Hits 791 787 -4
+ Misses 93 92 -1
Partials 54 54 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
ruff-all-v0.3.4-pass
branch
2 times, most recently
from
March 24, 2024 21:25
07c2733 to
396f5e4
Compare
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .
Fixed 39 errors:
- conftest.py:
2 × PT003 (pytest-extraneous-scope-function)
1 × PIE790 (unnecessary-placeholder)
- docs/conf.py:
1 × RET505 (superfluous-else-return)
- scripts/generate_gitlab.py:
5 × T201 (print)
- src/vcspull/_internal/config_reader.py:
4 × RET505 (superfluous-else-return)
1 × PLR6201 (literal-membership)
- src/vcspull/cli/__init__.py:
2 × TID252 (relative-imports)
1 × I001 (unsorted-imports)
1 × RET505 (superfluous-else-return)
- src/vcspull/cli/sync.py:
4 × TID252 (relative-imports)
- src/vcspull/config.py:
1 × PLR5501 (collapsible-else-if)
1 × E303 (too-many-blank-lines)
1 × RSE102 (unnecessary-paren-on-raise-exception)
1 × RET504 (unnecessary-assign)
- src/vcspull/exc.py:
1 × ISC001 (single-line-implicit-string-concatenation)
- src/vcspull/log.py:
2 × E303 (too-many-blank-lines)
2 × RET504 (unnecessary-assign)
1 × FLY002 (static-join-to-f-string)
- src/vcspull/util.py:
1 × PLR1733 (unnecessary-dict-index-lookup)
- tests/fixtures/example.py:
2 × PIE804 (unnecessary-dict-kwargs)
- tests/test_config.py:
1 × PT001 (pytest-fixture-incorrect-parentheses-style)
- tests/test_config_file.py:
2 × PT003 (pytest-extraneous-scope-function)
tony
force-pushed
the
ruff-all-v0.3.4-pass
branch
from
March 24, 2024 21:31
396f5e4 to
1795702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .Fixed 39 errors:
2 × PT003 (pytest-extraneous-scope-function)
1 × PIE790 (unnecessary-placeholder)
1 × RET505 (superfluous-else-return)
4 × RET505 (superfluous-else-return)
1 × PLR6201 (literal-membership)
src/vcspull/cli/__init__.py:2 × TID252 (relative-imports)
1 × I001 (unsorted-imports)
1 × RET505 (superfluous-else-return)
4 × TID252 (relative-imports)
1 × PLR5501 (collapsible-else-if)
1 × E303 (too-many-blank-lines)
1 × RSE102 (unnecessary-paren-on-raise-exception)
1 × RET504 (unnecessary-assign)
1 × ISC001 (single-line-implicit-string-concatenation)
2 × E303 (too-many-blank-lines)
2 × RET504 (unnecessary-assign)
1 × FLY002 (static-join-to-f-string)
1 × PLR1733 (unnecessary-dict-index-lookup)
2 × PIE804 (unnecessary-dict-kwargs)
1 × PT001 (pytest-fixture-incorrect-parentheses-style)
2 × PT003 (pytest-extraneous-scope-function)