Skip to content

Linting: Aggressive ruff pass (ruff v0.3.4) - #442

Merged
tony merged 4 commits into
masterfrom
ruff-all-v0.3.4-pass
Mar 24, 2024
Merged

Linting: Aggressive ruff pass (ruff v0.3.4)#442
tony merged 4 commits into
masterfrom
ruff-all-v0.3.4-pass

Conversation

@tony

@tony tony commented Mar 24, 2024

Copy link
Copy Markdown
Member
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .

Fixed 39 errors:

  • conftest.py:
    2 × PT003 (pytest-extraneous-scope-function)
    1 × PIE790 (unnecessary-placeholder)
  • docs/conf.py:
    1 × RET505 (superfluous-else-return)
  • src/vcspull/_internal/config_reader.py:
    4 × RET505 (superfluous-else-return)
    1 × PLR6201 (literal-membership)
  • src/vcspull/cli/__init__.py:
    2 × TID252 (relative-imports)
    1 × I001 (unsorted-imports)
    1 × RET505 (superfluous-else-return)
  • src/vcspull/cli/sync.py:
    4 × TID252 (relative-imports)
  • src/vcspull/config.py:
    1 × PLR5501 (collapsible-else-if)
    1 × E303 (too-many-blank-lines)
    1 × RSE102 (unnecessary-paren-on-raise-exception)
    1 × RET504 (unnecessary-assign)
  • src/vcspull/exc.py:
    1 × ISC001 (single-line-implicit-string-concatenation)
  • src/vcspull/log.py:
    2 × E303 (too-many-blank-lines)
    2 × RET504 (unnecessary-assign)
    1 × FLY002 (static-join-to-f-string)
  • src/vcspull/util.py:
    1 × PLR1733 (unnecessary-dict-index-lookup)
  • tests/fixtures/example.py:
    2 × PIE804 (unnecessary-dict-kwargs)
  • tests/test_config.py:
    1 × PT001 (pytest-fixture-incorrect-parentheses-style)
  • tests/test_config_file.py:
    2 × PT003 (pytest-extraneous-scope-function)

@tony
tony force-pushed the ruff-all-v0.3.4-pass branch from 31596d0 to bc7da59 Compare March 24, 2024 17:52
@codecov

codecov Bot commented Mar 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.35%. Comparing base (7297ba5) to head (1795702).

Files Patch % Lines
src/vcspull/_internal/config_reader.py 20.00% 2 Missing and 2 partials ⚠️
src/vcspull/log.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   84.32%   84.35%   +0.02%     
==========================================
  Files          16       16              
  Lines         938      933       -5     
  Branches      182      182              
==========================================
- Hits          791      787       -4     
+ Misses         93       92       -1     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony
tony force-pushed the ruff-all-v0.3.4-pass branch 2 times, most recently from 07c2733 to 396f5e4 Compare March 24, 2024 21:25
tony added 4 commits March 24, 2024 16:31
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .

Fixed 39 errors:
- conftest.py:
    2 × PT003 (pytest-extraneous-scope-function)
    1 × PIE790 (unnecessary-placeholder)
- docs/conf.py:
    1 × RET505 (superfluous-else-return)
- scripts/generate_gitlab.py:
    5 × T201 (print)
- src/vcspull/_internal/config_reader.py:
    4 × RET505 (superfluous-else-return)
    1 × PLR6201 (literal-membership)
- src/vcspull/cli/__init__.py:
    2 × TID252 (relative-imports)
    1 × I001 (unsorted-imports)
    1 × RET505 (superfluous-else-return)
- src/vcspull/cli/sync.py:
    4 × TID252 (relative-imports)
- src/vcspull/config.py:
    1 × PLR5501 (collapsible-else-if)
    1 × E303 (too-many-blank-lines)
    1 × RSE102 (unnecessary-paren-on-raise-exception)
    1 × RET504 (unnecessary-assign)
- src/vcspull/exc.py:
    1 × ISC001 (single-line-implicit-string-concatenation)
- src/vcspull/log.py:
    2 × E303 (too-many-blank-lines)
    2 × RET504 (unnecessary-assign)
    1 × FLY002 (static-join-to-f-string)
- src/vcspull/util.py:
    1 × PLR1733 (unnecessary-dict-index-lookup)
- tests/fixtures/example.py:
    2 × PIE804 (unnecessary-dict-kwargs)
- tests/test_config.py:
    1 × PT001 (pytest-fixture-incorrect-parentheses-style)
- tests/test_config_file.py:
    2 × PT003 (pytest-extraneous-scope-function)
@tony
tony force-pushed the ruff-all-v0.3.4-pass branch from 396f5e4 to 1795702 Compare March 24, 2024 21:31
@tony
tony merged commit 7d415db into master Mar 24, 2024
@tony
tony deleted the ruff-all-v0.3.4-pass branch March 24, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant