fix(types) Eliminate runtime dependency on ConfigDict - #476
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 79.10% 79.08% -0.03%
==========================================
Files 14 14
Lines 1527 1525 -2
Branches 321 321
==========================================
- Hits 1208 1206 -2
Misses 201 201
Partials 118 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigDictimport behindTYPE_CHECKINGso production installs no longer requiretyping-extensionsat runtime while keeping the same annotations for tooling.tests/cli/test_status.pyfixtures to keep using the sharedConfigDictalias without violating the new guard pattern.CHANGESso downstream users know why the import order changed.Testing
uv run ruff check . --fix --show-fixesuv run ruff format .uv run mypyuv run py.test