Conversation
Build both Poco and BoringSSL in FIPS mode. For BoringSSL that means build according to the golang 1.19 process, borrowing some code from golang sourcecode
Patching /contrib/krb5/src/lib/crypto/openssl/enc_provider/aes.c to be compatible with used version of BoringSSL
Enmk
force-pushed
the
22.8-fips-go1.19-boringssl
branch
from
January 12, 2023 20:50
8c22555 to
b1d5419
Compare
Not setting OPENSSL_FIPS - causes Poco to choose old TLSv1 Using BoringSSL's FIPS_mode() to determine if in FIPS mode.
Tuned CI/CD for FIPs build
This is required for break-hash tests Symbols that are explicitly kept: * BORINGSSL_bcm_rodata_start * BORINGSSL_bcm_rodata_end * BORINGSSL_bcm_text_start * BORINGSSL_bcm_text_end
Disabled doing performance tests, as we don't need it and it causes troubles
Added FIPS_CLICKHOUSE to system.build_options
Collaborator
Author
|
Close to reopen later |
Collaborator
Author
|
replaced by #235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building CH, BoringSSL, and Poco in FIPS mode.
There is a main option
FIPS_CLICKHOUSEthat turns on special build rules for BoringSSL and some other minor adjustments.BoringSSL is built using recipes of go1.19, that is:
go1.19)There are some minor modifications to ClickHouse code:
const_cast<X509 *>s to match API of BoringSSL version/contrib/krb5/src/lib/crypto/openssl/enc_provider/aes.csince it includes missing header.