[SPARK-59893][INFRA][TEST] Fix npm vulnerabilities in dev and ui-test - #59156
Closed
LuciferYang wants to merge 1 commit into
Closed
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Oct 1, 2026
Contributor
Author
|
Merge Summary:
Posted by |
Contributor
Author
|
Thank you @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This regenerates the two
package-lock.jsonfiles withnpm audit fix --package-lock-only, movingbrace-expansionpast the advisory range in both npm projects. Only the lockfiles change; nopackage.jsonand no direct dependency is touched.Version moves:
dev:brace-expansion1.1.18 -> 1.1.21,fast-uri3.1.7 -> 3.1.8.ui-test:brace-expansion1.1.18 -> 1.1.21 (undertest-exclude), 2.1.4 -> 2.1.7 (under@jest/reporters,jest-config,jest-runtime), and 5.0.9 -> 5.0.12 (top level).Why are the changes needed?
brace-expansionGHSA-q2hr-2g5m-vwhr: quadratic-time expansion of the{a},b}rewrite causes a CPU denial of service.npm auditalso flags two recursion advisories that the same patched releases close: GHSA-qhr7-859c-m2p7 (stack exhaustion on nested brace groups) and GHSA-6j4f-fj2g-mc7p (stack exhaustion inparseCommaParts). All resolve in range.This addresses https://github.com/apache/spark/security/dependabot/246, https://github.com/apache/spark/security/dependabot/254, https://github.com/apache/spark/security/dependabot/255 and https://github.com/apache/spark/security/dependabot/256.
The
devrun also carriesfast-uri3.1.7 -> 3.1.8, which clears GHSA-hrr3-gc8f-f4qj (inconsistent host case normalization via percent-encoded octets, moderate) so the audit comes back clean.These are dev/test-only dependencies, but it is worth keeping the audit clean.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
npm auditreports 0 vulnerabilities in both projects afterward, andnpm cireproduces both lockfiles unmodified. GitHub Actions does not runnpm auditornpm ci.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8