Conversation
Bump the pinned score_persistency commit to eclipse-score/persistency@d2b65ed (merged PR #435), which rewrote the module verification report to use the docs-as-code post_template mechanism natively. - Remove patches/persistency/001-add-mod-need.patch, 002-rename-manual-verification-report-id.patch and 006-add-module-index-title.patch: all three are now applied/obsolete upstream (verified via dry-run patch testing against the new commit). - Keep 003/004/005 (pip/imagefs/googletest not-dev-dependency fixes): regenerated against the new commit since their context had drifted from unrelated upstream dependency bumps; still required because eclipse-score/persistency#434 is not yet merged. - Remove the redundant local wrapper docs/verification_report/modules/persistency/persistency_verification_report.rst, which duplicated persistency's own post_template need under the same id. docs/verification_report/modules/index.rst now links directly to persistency's own bundled verification report (modules/score_persistency/verification_report/module_verification_report) instead of the local duplicate. - known_good.json and the generated bazel_common/score_modules_target_sw.MODULE.bazel were updated together via scripts/known_good/update_module_from_known_good.py.
antonkri
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
September 23, 2026 13:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned
score_persistencycommit tod2b65ed(merged eclipse-score/persistency#435), which rewrote persistency's own module
verification report to use the docs-as-code
post_templatemechanismnatively, and removes the reference_integration patches/wrapper that are no
longer needed as a result.
Changes
known_good.json/bazel_common/score_modules_target_sw.MODULE.bazel(regenerated via
scripts/known_good/update_module_from_known_good.py):bump the
score_persistencycommit.Removed obsolete patches (verified obsolete via dry-run patch testing
against the new commit):
patches/persistency/001-add-mod-need.patchpatches/persistency/002-rename-manual-verification-report-id.patchpatches/persistency/006-add-module-index-title.patchRegenerated (still-needed) patches, since their context had drifted due
to unrelated upstream dependency bumps (e.g.
googletest,score_rules_imagefs,score_bazel_cpp_toolchainsversion changes):patches/persistency/003-pip-not-dev-dependency.patchpatches/persistency/004-imagefs-not-dev-dependency.patchpatches/persistency/005-googletest-not-dev-dependency.patchThese three are kept because fix: mark pip, score_rules_imagefs and googletest as non-dev dependencies persistency#434 (the
corresponding upstream fix) is not yet merged.
Docs restructuring: removed the redundant local wrapper
docs/verification_report/modules/persistency/persistency_verification_report.rst,which duplicated persistency's own
post_templateneed under the same:id:(doc__persistency_verification_report) — this wrapper also had astale
:need:reference todoc__persistency_manual_verification_report,which no longer exists upstream.
docs/verification_report/modules/index.rstnow links directly to persistency's own bundled verification report
(
modules/score_persistency/verification_report/module_verification_report)instead of the local duplicate.
Validation
bazel mod deps --lockfile_mode=update(module resolution succeeds, nopatch-application errors).
MODULE.bazel.lockis unaffected (no diff after the resolution run).bazel run //:docsbuild was not attempted locally (known to beheavy/OOM-prone in constrained environments); the docs change was reviewed
manually against the
docs_bundles.bzlmount convention(
mount_at = "modules/score_persistency").