Skip to content

chore(deps): bump score_persistency pin, drop obsolete patches - #365

Open
antonkri wants to merge 1 commit into
mainfrom
update-persistency-pin-pr435
Open

antonkri wants to merge 1 commit into
mainfrom
update-persistency-pin-pr435

Conversation

@antonkri

Copy link
Copy Markdown
Contributor

Summary

Bumps the pinned score_persistency commit to
d2b65ed
(merged eclipse-score/persistency#435), which rewrote persistency's own module
verification report to use the docs-as-code post_template mechanism
natively, and removes the reference_integration patches/wrapper that are no
longer needed as a result.

Changes

  • known_good.json / bazel_common/score_modules_target_sw.MODULE.bazel
    (regenerated via scripts/known_good/update_module_from_known_good.py):
    bump the score_persistency commit.

  • Removed obsolete patches (verified obsolete via dry-run patch testing
    against the new commit):

    • patches/persistency/001-add-mod-need.patch
    • patches/persistency/002-rename-manual-verification-report-id.patch
    • patches/persistency/006-add-module-index-title.patch
  • Regenerated (still-needed) patches, since their context had drifted due
    to unrelated upstream dependency bumps (e.g. googletest,
    score_rules_imagefs, score_bazel_cpp_toolchains version changes):

    • patches/persistency/003-pip-not-dev-dependency.patch
    • patches/persistency/004-imagefs-not-dev-dependency.patch
    • patches/persistency/005-googletest-not-dev-dependency.patch

    These three are kept because fix: mark pip, score_rules_imagefs and googletest as non-dev dependencies persistency#434 (the
    corresponding upstream fix) is not yet merged.

  • Docs restructuring: removed the redundant local wrapper
    docs/verification_report/modules/persistency/persistency_verification_report.rst,
    which duplicated persistency's own post_template need under the same
    :id: (doc__persistency_verification_report) — this wrapper also had a
    stale :need: reference to doc__persistency_manual_verification_report,
    which no longer exists upstream.
    docs/verification_report/modules/index.rst
    now links directly to persistency's own bundled verification report
    (modules/score_persistency/verification_report/module_verification_report)
    instead of the local duplicate.

Validation

  • All patches verified to apply cleanly against the new commit via
    bazel mod deps --lockfile_mode=update (module resolution succeeds, no
    patch-application errors).
  • MODULE.bazel.lock is unaffected (no diff after the resolution run).
  • A full bazel run //:docs build was not attempted locally (known to be
    heavy/OOM-prone in constrained environments); the docs change was reviewed
    manually against the docs_bundles.bzl mount convention
    (mount_at = "modules/score_persistency").

Bump the pinned score_persistency commit to eclipse-score/persistency@d2b65ed
(merged PR #435), which rewrote the module verification report to use the
docs-as-code post_template mechanism natively.

- Remove patches/persistency/001-add-mod-need.patch,
  002-rename-manual-verification-report-id.patch and
  006-add-module-index-title.patch: all three are now applied/obsolete
  upstream (verified via dry-run patch testing against the new commit).
- Keep 003/004/005 (pip/imagefs/googletest not-dev-dependency fixes):
  regenerated against the new commit since their context had drifted
  from unrelated upstream dependency bumps; still required because
  eclipse-score/persistency#434 is not yet merged.
- Remove the redundant local wrapper
  docs/verification_report/modules/persistency/persistency_verification_report.rst,
  which duplicated persistency's own post_template need under the same
  id. docs/verification_report/modules/index.rst now links directly to
  persistency's own bundled verification report
  (modules/score_persistency/verification_report/module_verification_report)
  instead of the local duplicate.
- known_good.json and the generated
  bazel_common/score_modules_target_sw.MODULE.bazel were updated together
  via scripts/known_good/update_module_from_known_good.py.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant