[ntuple] Preparations for introducing slow merging in the RNTupleMerger - #23576
Open
silverweed wants to merge 1 commit into
Open
silverweed wants to merge 1 commit into
silverweed wants to merge 1 commit into
Conversation
Will help introducing the Slow merging path later
silverweed
force-pushed
the
ntuple_merge_slow_3_3
branch
from
October 2, 2026 07:40
8362a5c to
3612562
Compare
Test Results 23 files 23 suites 3d 19h 17m 34s ⏱️ For more details on these failures, see this check. Results for commit 3612562. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
refactors the RNTupleMerger to modularize a bit better the parts that depend on the merging strategy (slow or non-slow, aka L4 or L1/2/3).
A new interface,
RNTupleMergeStrategy, is introduced which provide the common functions that both strategy need to implement (currently only the non-slow strategy exists, calledRNTupleMergeStrategyDefault).Most of the code currently belonging to the
RNTupleMergerclass is moved into this strategy class, with no functional changes. The only actual changes in these functions are:RNTupleMergeDatastruct is removed as it's being replaced by the Strategy class itself (all its fields now belong to the Strategy);fNumDstEntriesfield of the mergeData is removed altogether because I realized it's not needed (replaced bydestination.GetNEntries().A later commit will introduce the slow merging strategy, with minimal impact on the existing code thanks to this change.
Checklist: