Conversation
To be used to keep track of how entry indexes percolate down to inner processors, instead of keeping track of that state in the objects itself.
This move the processor state bookkeeping from the processor itself to the iterator, making it possible to have multiple iterators for th same provessor without mixing up the entry state.
Test Results 24 files 24 suites 4d 0h 42m 37s ⏱️ For more details on these failures, see this check. Results for commit d16740a. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current RNTupleProcessor implementation internally stores bookkeeping information, which is tightly coupled to the iterator over it.
In practice this means that as the iterator advances, it always loads an entry, which is not necessarily desired. Moreover, it also means that it is not possible to have two separate iterators at the same time, because there will be some superposition situation going on.
This PR tries to address this by moving the bookkeeping to the iterator, through a new (read-only)
RNTupleProcessor::REntryMappingclass, which recursively keeps track of which entry to load from which RNTuple in the processor composition. The mapping gets uploaded as the iterator increases, but no entries get loaded untilLoadEntryis called by the application, which takes this mapping as an argument.This also means that there is a slight change to the API.
I've opened this PR initially as a draft to collect input on the general idea and direction.