Delete remaining Makefiles - #23599
Open
guitargeek wants to merge 6 commits into
Open
guitargeek wants to merge 6 commits into
guitargeek wants to merge 6 commits into
Conversation
All roottest tests are driven by CMake/ctest now (see root-project#23568). Delete the files left over from the make-based harness: - per-directory Makefiles that only include scripts/Rules.mk - scripts/{Rules,FixCling,Common,Disable,Event,Reflex}.mk - scripts/{Makefile,Makefile.template,subdirectories,run_cinttest.sh} - the old nightly/buildbot drivers that invoked make: scripts/{run-from-buildbot.sh,run_roottest.hostname.config} and scripts/roottestpath (only used by Rules.mk) Closes part of root-project#23582. 🤖 Done with the help of AI
Part of root-project#23582. 🤖 Done with the help of AI
config/Makefile-comp.in and config/Makefile.in were still configured into the build tree as config/Makefile.comp and config/Makefile.config, but nothing in ROOT references or installs them anymore; the configure_file calls already said 'Will be removed in future release'. etc/Makefile.arch was only kept for makefile-based user builds against an installed ROOT; it has no consumers inside the repository. Part of root-project#23582. 🤖 Done with the help of AI
Part of root-project#23582. 🤖 Done with the help of AI
Nearly all entries in roottest/.gitignore ignored artifacts produced by running the removed Makefile-based harness directly in the source tree (CMake-based tests write only to the build directory, see root-project#23568). Remove it so that any remaining test that still creates files in the source directory becomes visible as an untracked file, as suggested in root-project#23568 (comment). Editor/OS noise (.DS_Store, .gdb_history, .project, ...) is already covered by the top-level .gitignore. Part of root-project#23582. 🤖 Done with the help of AI
These were the machinery of the removed DrawTest.sh entry script and are already non-functional (they invoke ./Event, while the CMake target has been renamed to eventexe long ago). The drawtest functionality lives in roottest (root/treeformula/event, root/tree/fastcloningeventtree). Update test/Readme.md accordingly. Part of root-project#23582. 🤖 Done with the help of AI
Test Results 24 files 24 suites 4d 1h 3m 7s ⏱️ For more details on these failures, see this check. Results for commit 79342fd. |
dpiparo
approved these changes
Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23582.