Skip to content

Rename truncate methods on integers to narrow - #156974

Open
joshtriplett wants to merge 1 commit into
rust-lang:mainfrom
joshtriplett:truncate-to-narrow
Open

joshtriplett wants to merge 1 commit into
rust-lang:mainfrom
joshtriplett:truncate-to-narrow

Conversation

@joshtriplett

Copy link
Copy Markdown
Member

This makes them consistent with widen (formerly extend).

This makes them consistent with `widen` (formerly `extend`).
@joshtriplett joshtriplett added the T-libs-api [DEPRECATED; DO NOT USE] label May 26, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2026
@rustbot

rustbot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates

@jhpratt

jhpratt commented May 30, 2026

Copy link
Copy Markdown
Member

While I understand the reasoning, truncate feels clearer regarding the inherently lossy behavior of the method.

@rust-bors

rust-bors Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #157398) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

+1 to what @jhpratt said. That said, r=me if libs-api is happy with this direction (looks like it needs a rebase).

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2026
@clarfonthey clarfonthey added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api [DEPRECATED; DO NOT USE] labels Aug 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants