Skip to content

[EXPERIMENT] Nullable From conversions - #162029

Open
clarfonthey wants to merge 1 commit into
rust-lang:mainfrom
clarfonthey:nullable-from
Open

clarfonthey wants to merge 1 commit into
rust-lang:mainfrom
clarfonthey:nullable-from

Conversation

@clarfonthey

@clarfonthey clarfonthey commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

After seeing rust-lang/libs-team#872, wanted to see if From impls for these would be possible without inference issues.

@rustbot label:S-experimental

r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 30, 2026
@rustbot

This comment was marked as outdated.

@clarfonthey clarfonthey added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Aug 30, 2026
@clarfonthey clarfonthey added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Aug 30, 2026
@rust-log-analyzer

This comment has been minimized.

@rustbot

rustbot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- library/core/src/mem/mod.rs - mem::discriminant (line 1382) stdout ----
error[E0277]: the trait bound `*const _: From<&_doctest_main_library_core_src_mem_mod_rs_1382_0::Enum>` is not satisfied
    --> library/core/src/mem/mod.rs:1395:20
     |
1395 |         unsafe { *<*const _>::from(self).cast::<u8>() }
     |                    ^^^^^^^^ the trait `From<&_doctest_main_library_core_src_mem_mod_rs_1382_0::Enum>` is not implemented for `*const _`

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0277`.
Couldn't compile the test.

@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #129036) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants