fix misleading diagnostics and improve diagnostics of return type mismatch - #162926
Open
Hamdan-Khan wants to merge 1 commit into
Open
Hamdan-Khan wants to merge 1 commit into
Hamdan-Khan wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@rustbot reroll |
Member
|
@rustbot reroll |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
…match fixed misleading suggestions of adding a return and semicolon expression to an expression already in return position by adding a return position check. fixed duplicate emission of error 277 by de-duplicateing the suggestion `suggest_missing_break_or_return_expr`, where a failed normalization leads to E277
Hamdan-Khan
force-pushed
the
return-type-mismatch-diagnostics
branch
from
September 30, 2026 17:29
706c0b2 to
c608702
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
S-waiting-on-author
Contributor
Author
|
Hey @TaKO8Ki , sorry for the ping. Mind taking a look at this when you're free? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix misleading diagnostics and improve diagnostics of return type mismatch
Fixed misleading suggestions of adding a return and semicolon expression to an expression already in return position by adding a return position check.
Fixed duplicate emission of error 277 by de-duplicateing the suggestion
suggest_missing_break_or_return_expr, where a failed normalization leads to E277fixes: #162271