Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
&strappears as a function argument, we can inform LLVM that the length has a restricted range similar to what's already done for slices.The
tests/codegen-llvm/function-arguments.rsfile has a test that looks like it intended to check this scenario, but thefn strfunction uses a&[u8]argument rather than&str. Since there's also another identicalfn slicewith an&[u8]argument in this test, this appears to be an oversight.rust/tests/codegen-llvm/function-arguments.rs
Lines 183 to 187 in 36b04f3
rust/tests/codegen-llvm/function-arguments.rs
Lines 206 to 210 in 36b04f3
This issue was discovered by an LLM, but the PR was implemented by hand.