Don't suggest replacing foreign format specifiers in concat! output - #163371
Open
h-kurashina wants to merge 1 commit into
Open
h-kurashina wants to merge 1 commit into
h-kurashina wants to merge 1 commit into
Conversation
When a format string is not a literal in the source, e.g. when it is
produced by `concat!`, the offsets of printf- and shell-style
specifiers are relative to the expanded string rather than to the
source. `check_foreign!` still used them to place a machine-applicable
suggestion, which could rewrite unrelated source text such as turning
`concat!` into `c{}cat!`, or ICE when the span landed inside a
multibyte character.
When the format string is not a source literal, explain the
translation in a note instead, e.g. "`%d` should be written as `{}`",
and don't emit the suggestion. For specifiers that cannot be
translated, point the note at the whole format string argument
instead of a span computed from those offsets; the output is the same
as before. The output for format strings written as literals is
unchanged.
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @jackh726 (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #163368, which fixes the same class of bug for the format string parser's suggestions.
When a format string is not a literal in the source, e.g. when it is
produced by
concat!, the offsets of printf- and shell-stylespecifiers are relative to the expanded string rather than to the
source.
check_foreign!still used them to place a machine-applicablesuggestion, which could rewrite unrelated source text such as turning
concat!intoc{}cat!, or ICE when the span landed inside amultibyte character.
When the format string is not a source literal, explain the
translation in a note instead, e.g. "
%dshould be written as{}",and don't emit the suggestion. For specifiers that cannot be
translated, point the note at the whole format string argument
instead of a span computed from those offsets; the output is the same
as before. The output for format strings written as literals is
unchanged.