Conversation
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| #[rustc_intrinsic] | ||
| #[rustc_nounwind] | ||
| #[unstable(feature = "gpu_launch_sized_workgroup_mem", issue = "135513")] | ||
| #[unstable(feature = "gpu_launch_sized_workgroup_mem", issue = "135516")] |
There was a problem hiding this comment.
#135516 is the only shared memory issue I know of (thanks for fixing the typo!). I can create a new one if that’s more appropriate
There was a problem hiding this comment.
We typically have one tracking issue per feature. The issue should explicitly say which feature it is for. The nvptx situation seems to be quite messy with #135516 and #111199 both saying they are tracking stdarch_nvptx. Neither of them seems to be for gpu_launch_sized_workgroup_mem. Maybe this intrinsic should be moved to stdarch_nvptx but that sounds odd as it the intrinsic sounds more cross-platform than that.
Someone who knows all the relevant features here should go through this all and clean it up so that each feature has exactly one tracking issue that reflects what the feature is about and what the current status us.
There was a problem hiding this comment.
Yeah, it does seem like the better solution is to create a more general tracking issue, maybe for intrinsics::gpu in general? The two intrinsics in there are cross-platform after all, and it will only grow over time I assume.
There was a problem hiding this comment.
Taking a step back -- intrinsics are not meant to be stabilized ever. Instead we add public functions in a proper place that invoke the intrinsics, and only those functions ever get stabilized. Why does this one have a feature gate?
|
@rustbot author Yeah, intrinsics generally don't have stability attributes; we only stabilize other functions that call them. Will wait for the discussion to decide what to do with this. |
|
Reminder, once the PR becomes ready for a review, use |
No description provided.