Skip to content

fix(docs): tracking issue for gpu_launch_sized_workgroup_mem - #163400

Open
xkevio wants to merge 1 commit into
rust-lang:mainfrom
xkevio:patch-2
Open

xkevio wants to merge 1 commit into
rust-lang:mainfrom
xkevio:patch-2

Conversation

@xkevio

@xkevio xkevio commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot

rustbot commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in library/core/src/intrinsics/gpu.rs

cc @Flakebi

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 27, 2026
@rustbot

rustbot commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

#[rustc_intrinsic]
#[rustc_nounwind]
#[unstable(feature = "gpu_launch_sized_workgroup_mem", issue = "135513")]
#[unstable(feature = "gpu_launch_sized_workgroup_mem", issue = "135516")]

@RalfJung RalfJung Sep 27, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#135516 does not mention this feature either?

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the one mentioned by @Flakebi as the Tracking Issue in #146181 which implements this feature, so I figured it might be more appropriate.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#135516 is the only shared memory issue I know of (thanks for fixing the typo!). I can create a new one if that’s more appropriate

@RalfJung RalfJung Sep 28, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically have one tracking issue per feature. The issue should explicitly say which feature it is for. The nvptx situation seems to be quite messy with #135516 and #111199 both saying they are tracking stdarch_nvptx. Neither of them seems to be for gpu_launch_sized_workgroup_mem. Maybe this intrinsic should be moved to stdarch_nvptx but that sounds odd as it the intrinsic sounds more cross-platform than that.

Someone who knows all the relevant features here should go through this all and clean it up so that each feature has exactly one tracking issue that reflects what the feature is about and what the current status us.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does seem like the better solution is to create a more general tracking issue, maybe for intrinsics::gpu in general? The two intrinsics in there are cross-platform after all, and it will only grow over time I assume.

@RalfJung RalfJung Sep 28, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a step back -- intrinsics are not meant to be stabilized ever. Instead we add public functions in a proper place that invoke the intrinsics, and only those functions ever get stabilized. Why does this one have a feature gate?

@clarfonthey

Copy link
Copy Markdown
Contributor

@rustbot author

Yeah, intrinsics generally don't have stability attributes; we only stabilize other functions that call them. Will wait for the discussion to decide what to do with this.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2026
@rustbot

rustbot commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants