Update std_detect support for AArch64 Darwin - #163516
pthariensflame wants to merge 1 commit into
Conversation
Current as of late September, 2026.
|
Some changes occurred in cc @Amanieu, @folkertdev, @sayantn |
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| enable_feature(Feature::flagm2, flagm2); | ||
| enable_feature(Feature::fp, fp); | ||
| enable_feature(Feature::fp16, fp16); | ||
| enable_feature(Feature::fp8, fp8); |
There was a problem hiding this comment.
This doesn't match the Linux check:
rust/library/std_detect/src/detect/os/linux/aarch64.rs
Lines 372 to 373 in c1bf6e1
Note that the fp8 feature was changed in LLVM to depend on just neon rather than FeatureFAMINMAX, FeatureLUT, FeatureBF16 in llvm/llvm-project#125874. But rustc still lists those three features. Should this also be updated to match LLVM?
There was a problem hiding this comment.
We have no idea; who would be the best person to consult for this?
There was a problem hiding this comment.
Hopefully one of the people cc'd above by the bot can help.
There was a problem hiding this comment.
cc @davidtwco @adamgemmell (target maintainers), but seems to me that we should follow LLVM here?
There was a problem hiding this comment.
Unfortunately it's a breaking change to do so as this example would require an unsafe context on the call:
#[target_feature(enable="fp8")]
fn fp8() {
bf16();
}
#[target_feature(enable="bf16")]
fn bf16() {}
There was a problem hiding this comment.
Unfortunately it's a breaking change to do so as this example would require an unsafe context on the call
Would that be potentially solvable by use of a new feature (fp8cvt, name subject to bikeshedding) to represent the actual FEAT_FP8 and then redefining fp8 retroactively to imply fp8cvt+lut+bf16+faminmax?
Or is it okay to do this breaking change as fp8 is currently unstable anyway?
There was a problem hiding this comment.
Oh, if fp8 is still unstable then we can just make that change :)
This makes it current as of late September, 2026.
No part of this was done using LLMs in any capacity.