borrowck: suggest explicit &_ annotations for unannotated closure arguments on E0597 - #163648
Open
raushan728 wants to merge 2 commits into
Open
raushan728 wants to merge 2 commits into
raushan728 wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
raushan728
force-pushed
the
issues/163475
branch
from
October 2, 2026 12:44
c96e2ce to
abfca95
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163475
When an
E0597borrow error is caused by passing a borrowed local into an unannotated closure parameter, the inferred lifetime is often too large.This PR traces the MIR def-use chain to the exact closure argument and suggests explicitly annotating the parameter to make it higher-ranked.
r? @GuillaumeGomez