Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…sis if it's not necessary
blyxyas
force-pushed
the
go-to-stage-flag
branch
from
October 5, 2026 14:53
14e90d3 to
fe20e9e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
jackh726
requested changes
Oct 5, 2026
Member
There was a problem hiding this comment.
I don't think we should add a new flag here - I think we should be reusing --emit.
I think we likely need a couple things:
- We need to
ANALYSISandANALYSIS_FULL(or similar) output types to stop immediately after required and full analyses. - I don't think we should be doing something like "if emitting depinfo and nothing else" but rather "needs XYZ". Because we may want to do `--emit=depinfo,metadata"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a go-to-stage flag, this flag makes the compiler exit after a certain stage. Currently it recognizes
end(the default which is effectively a no-op),analysisfor stopping afteranalysisandnameresfor stopping just after name resolution.analysisis similar to--emit=metadatawithoutlink, andnamereswill be used for the probe run in Cargo (See blyxyas/incr-systems#4)Related to blyxyas/incr-systems#3 and rust-lang/goals#641
r? @jackh726