[css-transitions] revert inside @starting-style drops lower-layer @starting-style declarations - #63273
Open
Ahmad-S792 wants to merge 1 commit into
Open
[css-transitions] revert inside @starting-style drops lower-layer @starting-style declarations#63273Ahmad-S792 wants to merge 1 commit into
Ahmad-S792 wants to merge 1 commit into
Conversation
…arting-style declarations This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. The rollback cascades built for revert, revert-layer and revert-rule hardcoded their included property types to normalProperties(), which does not contain PropertyType::StartingStyle. As a result, addMatch() dropped every @starting-style declaration from the rollback cascade, so a revert used inside an @starting-style rule could not roll back to an @starting-style declaration from a lower priority layer or origin and instead behaved like "unset". Propagate the parent cascade's StartingStyle property type into the rollback cascade so starting-style declarations remain visible during rollback. WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=325359 WebKit-Canonical-Link: https://commits.webkit.org/322688@main
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
The rollback cascades built for revert, revert-layer and revert-rule hardcoded their included property types to normalProperties(), which does not contain PropertyType::StartingStyle. As a result, addMatch() dropped every @starting-style declaration from the rollback cascade, so a revert used inside an @starting-style rule could not roll back to an @starting-style declaration from a lower priority layer or origin and instead behaved like "unset".
Propagate the parent cascade's StartingStyle property type into the rollback cascade so starting-style declarations remain visible during rollback.
WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=325359
WebKit-Canonical-Link: https://commits.webkit.org/322688@main