BERJAYA

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pablogsal
Recipients	gregory.p.smith, pablogsal, petr.viktorin
Date	2021-04-04.21:11:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
Ok, so seems that PR25188 works if the abi dump file for the "correct" version is generated with the same compiler that is used to check the ABI. I think this is acceptable if the workflow is: - As soon as a version is released, we generate in the stable release branch the dump using some docker container with the same compiler as the GitHub CI. - We enable the ABI check only for release branches. - We should make the check mandatory because release managers cannot be checking all backport PRs unfortunately. We make the changes for 3.8 and 3.9 for the time being.

Ok, so seems that PR25188 works if the abi dump file for the "correct" version is generated with the same compiler that is used to check the ABI. I think this is acceptable if the workflow is:

- As soon as a version is released, we generate in the stable release branch the dump using some docker container with the same compiler as the GitHub CI.

- We enable the ABI check only for release branches.

- We should make the check mandatory because release managers cannot be checking all backport PRs unfortunately.

We make the changes for 3.8 and 3.9 for the time being.

History
Date	User	Action	Args
2021-04-04 21:11:30	pablogsal	set	recipients: + pablogsal, gregory.p.smith, petr.viktorin
2021-04-04 21:11:30	pablogsal	set	messageid: <[email protected]>
2021-04-04 21:11:30	pablogsal	link	issue43725 messages
2021-04-04 21:11:30	pablogsal	create