Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 16, 2026

Reworked the shared FIFO handler to first run handle_cmd which allows overriding the commands. Then added a check in SetVersion to check for minimum required version

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-1971-fail-if-memory-isnt-supported-by-integration (d706f21) with main (3150477)

Open in CodSpeed

@not-matthias not-matthias removed the request for review from GuillaumeLagrange January 16, 2026 16:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the FIFO command handling to allow executor-specific overrides of commands before falling back to shared implementation. It adds version checking in the memory executor to fail early if the integration doesn't support memory profiling (protocol version < 2).

Changes:

  • Refactored handle_fifo_messages to use a two-stage approach: executor-specific handler first, then shared implementation
  • Added protocol version check in memory executor to enforce minimum version 2 requirement
  • Updated return type from FifoCommand to Option<FifoCommand> for the handler callback

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/executor/shared/fifo.rs Refactored command handling to invoke custom handler first, then fall back to shared implementation; added default error response for unhandled commands
src/executor/wall_time/perf/mod.rs Updated perf executor to return Option<FifoCommand> and removed duplicate error handling
src/executor/memory/executor.rs Added SetVersion command handler to check for minimum protocol version 2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing, not sure why, ping me for quick re-review

@not-matthias not-matthias force-pushed the cod-1971-fail-if-memory-isnt-supported-by-integration branch 2 times, most recently from 0a8c23d to f22e5a2 Compare January 19, 2026 18:22
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias force-pushed the cod-1971-fail-if-memory-isnt-supported-by-integration branch from f22e5a2 to d706f21 Compare January 20, 2026 17:26
@not-matthias not-matthias merged commit d706f21 into main Jan 20, 2026
13 checks passed
@not-matthias not-matthias deleted the cod-1971-fail-if-memory-isnt-supported-by-integration branch January 20, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants