-
Notifications
You must be signed in to change notification settings - Fork 6
fix: fail if memtrack isn't supported #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail if memtrack isn't supported #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the FIFO command handling to allow executor-specific overrides of commands before falling back to shared implementation. It adds version checking in the memory executor to fail early if the integration doesn't support memory profiling (protocol version < 2).
Changes:
- Refactored
handle_fifo_messagesto use a two-stage approach: executor-specific handler first, then shared implementation - Added protocol version check in memory executor to enforce minimum version 2 requirement
- Updated return type from
FifoCommandtoOption<FifoCommand>for the handler callback
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/executor/shared/fifo.rs | Refactored command handling to invoke custom handler first, then fall back to shared implementation; added default error response for unhandled commands |
| src/executor/wall_time/perf/mod.rs | Updated perf executor to return Option<FifoCommand> and removed duplicate error handling |
| src/executor/memory/executor.rs | Added SetVersion command handler to check for minimum protocol version 2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are failing, not sure why, ping me for quick re-review
0a8c23d to
f22e5a2
Compare
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
f22e5a2 to
d706f21
Compare
Reworked the shared FIFO handler to first run
handle_cmdwhich allows overriding the commands. Then added a check in SetVersion to check for minimum required version