chore: add ci to test deploy with helm#377

liangyuanpeng · 2025-04-24T08:37:19Z

What this PR does / why we need it

Yesterday, I attempted to deploy llmaz using helm, but encountered some issues. This PR fixed the problems and added a CI to ensure that the helm deployment was problem-free.

/kind cleanup

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Lan Liang <gcslyp@gmail.com>

liangyuanpeng · 2025-04-24T08:38:54Z

.github/workflows/test-chart.yaml

+          go-version-file: go.mod
+
+      - name: Set up Helm
+        uses: azure/setup-helm@v4


Perhaps the preference is to complete the installation of helm in the Makefile. Here, it's just a quick start. I'd be more than happy to update. like add a command: make helm to install helm.

Feel free to polish this in the follow up.

liangyuanpeng · 2025-04-24T08:42:33Z

hack/test-deploy-with-helm.sh

+export CWD=$(pwd)
+function cleanup {
+    if [ $USE_EXISTING_CLUSTER == 'false' ]
+    then
+        $KIND delete cluster --name $KIND_CLUSTER_NAME
+    fi
+}
+function startup {
+    if [ $USE_EXISTING_CLUSTER == 'false' ]
+    then
+        $KIND create cluster --name $KIND_CLUSTER_NAME --image $E2E_KIND_NODE_VERSION --config ./hack/kind-config.yaml
+    fi
+}
+function kind_load {
+    $KIND load docker-image $IMAGE_TAG --name $KIND_CLUSTER_NAME
+}
+function deploy {
+    cd $CWD
+    HELM_EXT_OPTS='--namespace=llmaz-system --create-namespace --set controllerManager.manager.image.tag=${LOADER_IMAGE_TAG}' make helm-install
+    $KUBECTL wait --timeout=3m --for=condition=ready pods --namespace=llmaz-system -l app!=certgen
+    echo "all pods of llmaz-system is ready..."
+    $KUBECTL get pod -n llmaz-system
+}
+function deploy_kube_prometheus {
+    LATEST=$(curl -s https://api.github.com/repos/prometheus-operator/prometheus-operator/releases/latest | jq -cr .tag_name)
+    curl -sL https://github.com/prometheus-operator/prometheus-operator/releases/download/${LATEST}/bundle.yaml | $KUBECTL  create -f -
+}
+trap cleanup EXIT
+startup
+kind_load
+deploy_kube_prometheus
+deploy


Just quickly work, I am very willing to reuse it in util.sh in this PR or the next PR.

liangyuanpeng · 2025-04-24T08:43:45Z

chart/Chart.yaml

-    repository: "oci://registry-1.docker.io/envoyproxy/"
+    repository: "oci://registry-1.docker.io/envoyproxy"
    condition: envoy-gateway.enabled
  - name: ai-gateway-helm
    version: v0.0.0-latest
-    repository: "oci://registry-1.docker.io/envoyproxy/"
+    repository: "oci://registry-1.docker.io/envoyproxy"


I just got the error when I run make helm-install , but this change fixed it.

... Downloading open-webui from repo https://helm.openwebui.com/ Downloading gateway-helm from repo oci://registry-1.docker.io/envoyproxy/ Save error occurred: could not download oci://registry-1.docker.io/envoyproxy//gateway-helm: invalid_reference: invalid repository Error: could not download oci://registry-1.docker.io/envoyproxy//gateway-helm: invalid_reference: invalid repository

Thanks, it's strange, I didn't encounter this. I will ask someone else to verify this because it may break users like you.

kerthcet

General LGTM.

kerthcet · 2025-04-24T08:54:39Z

.github/workflows/test-chart.yaml

+    branches-ignore:
+      - 'dependabot/**'
+  pull_request:
+    # paths:


Should we only check the chart/** ? I think we're only verifying that the helm chart is deployed as expected not the function, right?

kerthcet · 2025-04-24T08:56:23Z

.github/workflows/test-chart.yaml

+          go-version-file: go.mod
+
+      - name: Set up Helm
+        uses: azure/setup-helm@v4


Feel free to polish this in the follow up.

kerthcet · 2025-04-24T08:57:33Z

hack/test-deploy-with-helm.sh

+    $KUBECTL get pod -n llmaz-system
+}
+function deploy_kube_prometheus {
+    LATEST=$(curl -s https://api.github.com/repos/prometheus-operator/prometheus-operator/releases/latest | jq -cr .tag_name)


We may make the prometheus operator as a dependency of helm chart as well in the future.

kerthcet · 2025-04-24T08:59:22Z

hack/test-deploy-with-helm.sh

+    cd $CWD
+    HELM_EXT_OPTS='--namespace=llmaz-system --create-namespace --set controllerManager.manager.image.tag=${LOADER_IMAGE_TAG}' make helm-install
+    $KUBECTL wait --timeout=3m --for=condition=ready pods --namespace=llmaz-system -l app!=certgen
+    echo "all pods of llmaz-system is ready..."


Suggested change

echo "all pods of llmaz-system is ready..."

echo "All pods of llmaz are ready..."

kerthcet · 2025-04-24T09:01:37Z

/kind cleanup

kerthcet · 2025-04-24T09:03:29Z

.github/workflows/test-chart.yaml

+  contents: read
+
+jobs:
+  chart-lint-test:


chart-deploy-verify?

kerthcet · 2025-04-25T02:45:38Z

kindly ping @liangyuanpeng

kerthcet · 2025-05-09T10:06:25Z

Hi @liangyuanpeng are you still working on this?

kerthcet · 2025-05-19T02:26:14Z

Ping @liangyuanpeng again, we're approaching the deadline of v0.2.0, and we're happy to have this ci guardrail.

kerthcet · 2025-06-02T02:13:58Z

Fixed in #432, since @liangyuanpeng is on vacation until 0923. Thanks for the efforts.
/close

chore: add ci to test deploy with helm

7cc7efd

Signed-off-by: Lan Liang <gcslyp@gmail.com>

InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 24, 2025

InftyAI-Agent requested a review from kerthcet April 24, 2025 08:37

liangyuanpeng commented Apr 24, 2025

View reviewed changes

kerthcet reviewed Apr 24, 2025

View reviewed changes

InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 24, 2025

kerthcet reviewed Apr 24, 2025

View reviewed changes

.github/workflows/test-chart.yaml

contents: read

jobs:

chart-lint-test:

Copy link

Member

kerthcet Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart-deploy-verify?

kerthcet mentioned this pull request May 9, 2025

fix: remove trailing slashes from envoyproxy repository URLs in Chart.yaml #407

Merged

kerthcet mentioned this pull request Jun 2, 2025

Add ci test with helm chart #432

Merged

InftyAI-Agent closed this Jun 2, 2025

	echo "all pods of llmaz-system is ready..."
	echo "All pods of llmaz are ready..."

Uh oh!

Comments

Conversation

liangyuanpeng commented Apr 24, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liangyuanpeng Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kerthcet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kerthcet commented Apr 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kerthcet commented Apr 25, 2025

Uh oh!

kerthcet commented May 9, 2025

Uh oh!

kerthcet commented May 19, 2025

Uh oh!

kerthcet commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liangyuanpeng Apr 24, 2025 •

edited

Loading