#1051 Add setting to display speed in mph #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This seems like good change. However, can we make it slightly more cleaner and generic? I would suggest we add two settings:
Then folks can change above to km/hr or miles/hr or miles/day whatever else they need for their specific vehicle type. |
Contributor
Author
|
Sounds good |
…actor Allows the user to specify any units they want and then convert the speed as appropriate. Defaults to m/s with a scale factor of 1.
Contributor
Author
|
I think this is ready to be merged in. Is there anything else I need to do? |
sytelus
added a commit
that referenced
this pull request
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.