Support pwsh (PS Core) in Select Default Shell on Windows

[Tyriar]

Code pointer: https://github.com/Microsoft/vscode/blob/e4b5bccf9364a0f678606d5bdfc18800854bf678/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts#L134-L145

[Tyriar]

FYI @TylerLeonhardt

[roottool]

Hi @Tyriar, Thank you for reviewing my PR. Can I try this issue again?
And can you check my recognition?

My recognition of this issue

I add the below between PowerShell and WSL Bash in expectedLocations.

'PowerShell Core' : [
 		`${process.env['ProgramW6432']}\\PowerShell\\6\\pwsh.exe`,
 		`${process.env['ProgramFiles']}\\PowerShell\\6\\pwsh.exe`,
 	],

Currently, the version of PowerShell Core is 6.2.
But I am worried that 6 in file path is changed by upgrading to 7.0.

[bergmeister]

I think this issue is more complex than it looks like:

• What if the user hasn't got PowerShell Core installed? Should Code detect that and only show the option if possible or just handle it gracefully?
• PowerShell Core is an MSI installer on Windows where the user can specify a non-default installation location. It is also cross-platform so paths on Linux will be different. We need to either get the installation location from the registry or just call pwsh as it is expected to be on the PATH variable. I assume this approach should then work for Linux as well.

[Tyriar]

@roottool that's the basics of it and I'd merge something like that.

@bergmeister anything on top of basic path detection would be great, if the path doesn't exist that's already handled, but pulling from the environment/registry are options to make this much more user friendly. FYI this command is only available on Windows as on Linux/Mac you normally configure your default shell via chsh and $SHELL.

[essentialexch]

Traditionally, on Windows you used %COMSPEC% for the command processor. That works in Windows, DOS, and OS/2.

For PowerShell and pwsh paths, I'd probably suggest looking at HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\PowerShell.exe and HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\pwsh.exe respectively. This would deal with the 6 vs. 7 issue that @roottool brought up.

I don't have WSL installed to see if WSL respects those also, but I'd guess it does. GIT does not.

I don't do enough js/ts to add these suggestions, but thought I'd add my 2 cents none-the-less.

Thanks.

[Tyriar]

The terminal used to default to COMSPEC, but ended up moving off it I think because everything assumes that's cmd.exe anyway so people don't change unlike $SHELL.

[bergmeister]

The PowerShell Core MSI adds itself to the PATH environment variable, could we just simply call pwsh?

[essentialexch]

We can do that for all of those, except git bash (and I am aware that some people choose the option to have it added to their path - I for one, did not). I had presumed from @Tyriar 's earlier comment that he didn't want to do that.