This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Closed
Conversation
Contributor
Author
|
How I'm thinking of splitting the steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Part of #405
So, this turned out to be a lot more involved than I imagined. Have decided to break it down into steps.
This is step 1: Create a new worker pool, with it's own vm/setup/everything.
PR is a proof of concept, very rough, need to clean everything up (and repeat myself less) - but wanted to get this out so you can see what's going on and comment on the approach.
For installation, our setup makes things such that there's only 1 plugin on the hub, which allows us to freely re-use other tasks as they stand. (as long as we don't mess up on reload - I'm thinking of banning reload on this thread).
Everytime a new task comes in, the install thread sets up the plugin, and returns if there's no problems. I've set things up so that this will be re-usable for #165 -> basically every time you want to test something, it begins with a fresh installation, running setup -> task -> teardown.
Some repetition is inevitable, but I think I've whittled it down to the minimum (except vm.ts, which will go away).
Also, naming is very much a WIP too
To investigate:
2. Pools missing logs
Checklist