client: Improve screen reader navigability of sources#1345
Merged
Conversation
- Turn sources into a list items rather than forms, only the inside is an actual form. - Turn the source titles into headings. - Mark the edit button as collapsed. - Add a placeholder when no sources are present.
This would just potentially clutter the accessibility tree. Also do not show any other content when loading.
It should fall back to font size.
This should have been done in 0432fed
For screen readers.
This was missed in 0432fed The menu element is removed from DOM by the time the deletion handler run so jQuery’s `parents()` function will not be able to locate the form. Let’s store an explicit reference to the form and pass it to the event handler.
|
Thanks @jtojnar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1344