Remove suffix from converted full size images.

[peterwilsoncc]

Remove the dimension suffix from the full size image when converted to a web safe type.

This prevents the full size image file names from having the same form as a sub-sized image, filename-widthxheight.ext. Instead the file name uses the original name with the new extension.

Includes tests from #7733 but modified to use HEIC for the conversion source.

Trac ticket: Core-62359

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27, peterwilsoncc, azaozz, apermo, flixos90, ironprogrammer.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[apermo]

Found one WPCS issue.

[felixarntz]

@peterwilsoncc This looks great to me, thanks for working on this.

I have one question, but I trust the tests passing over my question, so I'll already approve.

[azaozz]

Just tested this again (manually) and all seems to work properly.

• The name of the originally uploaded HEIC image is preserved after converting it, only the extension is different.
• If a file with the target name already exists, the name of the uploaded image is properly incremented. I.e. if image.jpg already exists in the uploads directory, and the user uploads image.heic, the latter is saved as image-1.heic, and all resulting sub-sizes and/or converted images have the -1 suffix.

[ironprogrammer]

Thanks, @peterwilsoncc! Just a couple quick nits here.

[mukeshpanchal27]

Thanks @peterwilsoncc ♥️

[mukeshpanchal27]

Nit-pick. Not blocking add end period in message.

[peterwilsoncc]

Merged r59379 / e1f052e

Thanks all for helping get this over the line.