fix: validate DIBv5 format before fallback to DIB in Windows clipboard #2861
+39
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the clipboard reader would return errUnsupported when DIBv5 data existed but had an unsupported BitCount. This change validates the DIBv5 format (BitCount == 32) before processing, and falls back to readImageDib() for any DIBv5 validation failures or when DIBv5 data is unavailable, ensuring more reliable clipboard image reading.
Open
Contributor
|
I'm testing this out on a few different windows based terminals. Can I ask where specifically you find improvements in providing the DIB fallback? |
Author
I found the problem when trying to paste a screenshot created using Snagit, a tool for taking and annotating screenshots. The DIB fallback is already there, but it fails when OC detects DIBv5 but can't decode the image (probably due to different bpp). With this change, OC detects DIBv5 and tries to read it. If it fails, it falls back to DIB. It worked great with Snagit. |
github-actions
bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f1dc981 to
3e15a39
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f8ee907 to
6a9856d
Compare
This was referenced Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows clipboard to properly fallback to DIB format when DIBv5 validation fails. Previously returned
errUnsupportedwhen DIBv5 had unsupported BitCount instead of trying DIB fallback.