[opt](scanner) optimize the number of threads of scanners, follow up #28640#30030
Merged
morningman merged 1 commit intoapache:masterfrom Jan 16, 2024
Merged
[opt](scanner) optimize the number of threads of scanners, follow up #28640#30030morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jan 16, 2024
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38978 ms |
TPC-DS: Total hot run time: 177775 ms |
ClickBench: Total hot run time: 30.39 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
pushed a commit
that referenced
this pull request
Jan 16, 2024
hello-stephen
pushed a commit
to hello-stephen/doris
that referenced
this pull request
Jan 19, 2024
…pache#28640 (apache#30030) follow up apache#28640, doris_scanner_thread_pool_thread_num may be to large in machines with 128 cores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
follow up #28640,
doris_scanner_thread_pool_thread_nummay be to large in machines with 128 cores.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...