adding support for Org in PayloadGenerator.ContactData#276
Merged
codebude merged 2 commits intoShane32:masterfrom Apr 28, 2021
Merged
adding support for Org in PayloadGenerator.ContactData#276codebude merged 2 commits intoShane32:masterfrom
codebude merged 2 commits intoShane32:masterfrom
Conversation
codebude
requested changes
Apr 27, 2021
Collaborator
codebude
left a comment
codebude
left a comment
There was a problem hiding this comment.
Could you please make the commented changes? Afterwards I will be happy to merge your request.
Collaborator
|
Thanks for your support @raganca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes/implements the following bugs/features:
What existing problem does the pull request solve?
No ability to generate a contact card with Organization.
Test plan
Ran unit tests with no issues.
I've successfully generated contact cards (VCard3) with the org parameter supplied.
Closing issues
Fixes #274