Conversation
|
I see now that this was also done in #384 . Didn't see it, since it was called ASCII, which it isn't :) |
|
Hi @gliljas , thanks for your PR and the work you put into it. I reviewed your PR as also the aforementioned PR #384 and decided for the latter at the end. Reason: I like the integration into the existing ASCIIQRCode more that having a another separate renderer with nearly the same use-case/output. Nevertheless your code was very inspiring and a took parts of your ideas into the codebase from #384. (E.g. the invert parameter as also the fixed size/capacity of the string builder.) Regarding the naming "ASCIIQRCode" and your note (it was called ASCII, which it isn't :)) on it, I added an explanation in the wiki which reads out as follows:
I hope this helps to avoid confusion. :-) |
Summary
This PR implements support for rendering QR codes using the block elements available in Unicode. Two lines can be rendered as one, using FULL BLOCK, UPPER HALF BLOCK and LOWER HALF BLOCK. While it would also be possible to use the quadrant characters, reducing the string length even further, they are very rarely implemented in fonts.
The name Utf8QRCode is definitely up for discussion :)