Closed
Conversation
Owner
Author
|
Merged upstream with Samourai-Wallet#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
SamouraiAPIand the existing Samourai MoyaProvider streamlines the code and eliminates duplicate code (most importantly the endpoint definition). Will make using a different endpoint (🧅) for all API calls easier.Note: Having the possibility to use testnet for
DEBUGbuilds would be great. It would make testing easier and less expensive. A comprehensive test suite would be awesome as well, but I'll have to give that some thought. Some things might be challenging to test properly in an automatic fashion.