Provide a consistent experience when interacting with dub fetch#2785
Closed
Geod24 wants to merge 1 commit intodlang:masterfrom
Closed
Provide a consistent experience when interacting with dub fetch#2785Geod24 wants to merge 1 commit intodlang:masterfrom
Geod24 wants to merge 1 commit intodlang:masterfrom
Conversation
'dub fetch doesNotExists' and 'dub fetch doesNotExists@1.0.0' were behaving differently, both when they succeeded and when they failed. Making them consistent was just a matter of deleting a few lines of code, allowing us to also remove a branch.
Geod24
commented
Jan 9, 2024
| enforceUsage(!name.canFindVersionSplitter, "Double version spec not allowed."); | ||
| logWarn("The '--version' parameter was deprecated, use %s@%s. Please update your scripts.", name, m_version); | ||
| dub.fetch(name, VersionRange.fromString(m_version), location, fetchOpts); | ||
| } else if (name.canFindVersionSplitter) { |
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 11 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5351328 bin/dub
-rough build time=67s
+executable size=5347232 bin/dub
+rough build time=64sFull build output |
Member
Author
|
Moved to #2786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'dub fetch doesNotExists' and 'dub fetch doesNotExists@1.0.0' were behaving differently, both when they succeeded and when they failed. Making them consistent was just a matter of deleting a few lines of code, allowing us to also remove a branch.