This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[WIP] [18.06] Fix CLI external-ca tests in swarm suite#23
Closed
cyli wants to merge 1 commit intodocker-archive:18.06from
cyli:18.06-fix-cli-external-ca-tests
Closed
[WIP] [18.06] Fix CLI external-ca tests in swarm suite#23cyli wants to merge 1 commit intodocker-archive:18.06from cyli:18.06-fix-cli-external-ca-tests
cyli wants to merge 1 commit intodocker-archive:18.06from
cyli:18.06-fix-cli-external-ca-tests
Conversation
the external CA correctly propagates the CA certificate along with the external CA URL. Update the tests to reflect that. Signed-off-by: cyli <cyli@twistedmatrix.com> (cherry picked from commit c238517)
|
Hmm...I see error from the tests: |
Author
|
This is because engine is specifying testing against 17.06-ce CLI, which did not have this behavior change, and there is currently no 18.06-ce CLI yet. :|. I believe, as per @thaJeztah, we have to move the tests elsewhere or re-write them to just use the API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/cli#1178 changed the CLI behavior so that
the external CA correctly propagates the CA certificate along with the
external CA URL. Update the tests to reflect that.
Signed-off-by: cyli cyli@twistedmatrix.com
(cherry picked from commit c238517)
This is a back port of moby#37442
cc @andrewhsu