Added langversion preview for FCS tests --- keep this open until we understand the failures#10140
Closed
ncave wants to merge 1 commit intodotnet:feature/fcswfrom
Closed
Added langversion preview for FCS tests --- keep this open until we understand the failures#10140ncave wants to merge 1 commit intodotnet:feature/fcswfrom
ncave wants to merge 1 commit intodotnet:feature/fcswfrom
Conversation
Contributor
|
@ncave , I think the individual test case needs to specify the version of F# that it needs. That way can have tests that ensure we don't break the old mechanism. So I don't think this is such a great idea. |
Contributor
Author
|
@KevinRansom Perhaps, although it would be nice to test backwards compatibility of preview features and make sure they're not breaking existing tests. Feel free to close this PR, it was just meant to illustrate that some FCS tests are currently broken in this feature branch with |
Contributor
KevinRansom
changed the title
Contributor
|
@ncave, nope, gonna keep it open for a bit, to ensure we figure out the failures. Since the FSharp5 PR didn't see these same failures. |
Contributor
|
I have fixed this as part of #9510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--langversion:previewfor FCS tests.