[wip] Possible reversion of 3283 (Tuple<...> regression with Item* and Rest properties)#4029
Closed
dsyme wants to merge 1 commit intodotnet:masterfrom
Closed
[wip] Possible reversion of 3283 (Tuple<...> regression with Item* and Rest properties)#4029dsyme wants to merge 1 commit intodotnet:masterfrom
dsyme wants to merge 1 commit intodotnet:masterfrom
Conversation
Contributor
|
I agree that this is a rather awkward position to be in, as it is unknown how much code has either:
But assuming that we do go this route, we should also have a quick test for the regression, which could then be updated when we complete the work to make them the same and allow for accessing those properties. |
Contributor
Author
|
I'm closing this in favour of forward-moving resolution #4034. We can reopen if we decide to move backwards instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be the best thing is to revert #3283 because of the gradual emergence of more serious cases of regressions in #3729
We should probably have a final think about this before doing it. The more expensive option mentioned in #3729 is possible, but takes significant dev and test time.
In particular his change in itself will break code that was written in the interim, including:
Tuple.Createand explicitly annotating with a return type ofTuple<A,B>andA*B.I've marked this as WIP since a reversion that breaks code makes me feel queasy.