Support value-type service keys in ActivatorUtilities.CreateFactory()#106075
Closed
steveharter wants to merge 1 commit intodotnet:mainfrom
Closed
Support value-type service keys in ActivatorUtilities.CreateFactory()#106075steveharter wants to merge 1 commit intodotnet:mainfrom
steveharter wants to merge 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
This was referenced Aug 7, 2024
steveharter
commented
Aug 7, 2024
| Expression.Constant(hasDefaultValue), | ||
| Expression.Constant(keyAttribute?.Key) }; | ||
| Expression.Convert(Expression.Constant(keyAttribute?.Key), typeof(object)) }; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Extra space here... To be removed
Member
|
@steveharter can you have a look at #106059 and see if it's an OK? |
Contributor
Author
|
Closing this PR in favor of #106059 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96140