Skip to content

[release/10.0] Investigating #123950#124068

Closed
jkotas wants to merge 2 commits intodotnet:release/10.0from
jkotas:test-rc10
Closed

[release/10.0] Investigating #123950#124068
jkotas wants to merge 2 commits intodotnet:release/10.0from
jkotas:test-rc10

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Feb 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 6, 2026 04:08
@jkotas jkotas marked this pull request as draft February 6, 2026 04:09
@jkotas jkotas added NO-REVIEW Experimental/testing PR, do NOT review it and removed area-PAL-coreclr labels Feb 6, 2026
@jkotas jkotas added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds compile-time diagnostic checks to investigate issue #123950. The changes introduce #error directives that will fail Linux builds if the HAVE_PTHREAD_CONDATTR_SETCLOCK and HAVE_CLOCK_MONOTONIC features are not available.

Changes:

  • Added #error directives in the fallback code paths for pthread condition attribute initialization on Linux
  • These checks are placed in two synchronization-related files: System.Native threading primitives and CoreCLR's synchronization manager

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/native/libs/System.Native/pal_threading.c Added compile-time error check in SystemNative_LowLevelMonitor_Create to verify pthread_condattr_setclock is available on Linux
src/coreclr/pal/src/synchmgr/synchmanager.cpp Added compile-time error check in CThreadSynchronizationInfo::InitializePreCreate to verify pthread_condattr_setclock is available on Linux

Copilot AI review requested due to automatic review settings February 6, 2026 05:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings February 6, 2026 06:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

#ifdef __linux__

#if !HAVE_CLOCK_MONOTONIC
//#error HAVE_CLOCK_MONOTONIC missing
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out error directive should either be removed or uncommented. Having commented-out preprocessor error directives in the codebase can be confusing and suggests incomplete investigation work. If this check is needed, it should be active; if not, it should be removed entirely.

Suggested change
//#error HAVE_CLOCK_MONOTONIC missing

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 6, 2026 06:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@jkotas jkotas changed the title Investigating #123950 [release/10.0] Investigating #123950 Feb 6, 2026
@jkotas jkotas closed this Feb 7, 2026
@jkotas jkotas deleted the test-rc10 branch February 7, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-PAL-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments