CallSiteRuntimeResolver. VisitFactory method implements adding IsInstanceOfType check

[AlexKuai]

var provider = new ServiceCollection()
    .AddSingleton(typeof(IHostedService), provider => new StringWriter())
    .BuildServiceProvider();
var hostedService = provider.GetService(typeof(IHostedService));

Using the above code, you will get an instance without any inheritance or implementation relationship.
I think we should throw an exception instead of getting an instance, which may cause problems in some cases.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

var provider = new ServiceCollection()
    .AddSingleton(typeof(IHostedService), provider => new StringWriter())
    .BuildServiceProvider();
var hostedService = provider.GetService(typeof(IHostedService));

Using the above code, you will get an instance without any inheritance or implementation relationship.
I think we should throw an exception instead of getting an instance, which may cause problems in some cases.

Author:	AlexKuai
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[davidfowl]

What is this fixing? Where is the issue and the unit test? Does this regress the performance in anyway?

[ghost]

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

[ghost]

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.